hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nanda kumar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12741) ADD support for KSM --createObjectStore command
Date Wed, 13 Dec 2017 13:40:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16289271#comment-16289271

Nanda kumar commented on HDFS-12741:

Thanks [~shashikant] for updating the patch, it looks pretty good to me.

Some minor NITs

{{getOzoneMetadirPath}} can be renamed to {{getOzoneMetaDirPath}}


{{if (!DFSUtil.isOzoneEnabled(conf))}} is done twice, inside {{main}} and in {{createKSM}}.
The one inside {{main}} can be removed.

Line:278 {{System.out.println}} should be {{System.err.println}}

Line:310 If {{clusterId}} is missing we should throw exception. In current patch we are continuing
with writing the version file without {{clusterId}} 

Line:313 Same as {{clusterId}}, we should throw error if {{scmId}} is missing. 

> ADD support for KSM --createObjectStore command
> -----------------------------------------------
>                 Key: HDFS-12741
>                 URL: https://issues.apache.org/jira/browse/HDFS-12741
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: HDFS-7240
>            Reporter: Shashikant Banerjee
>            Assignee: Shashikant Banerjee
>             Fix For: HDFS-7240
>         Attachments: HDFS-12741-HDFS-7240.001.patch, HDFS-12741-HDFS-7240.002.patch,
HDFS-12741-HDFS-7240.003.patch, HDFS-12741-HDFS-7240.004.patch, HDFS-12741-HDFS-7240.005.patch
> KSM --createObjectStore command reads the ozone configuration information and creates
the KSM version file and reads the SCM version file from the SCM specified.
> The SCM version file is stored in the KSM metadata directory and before communicating
with an SCM KSM verifies that it is communicating with an SCM where the relationship has been
established via createObjectStore command.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message