hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anu Engineer (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HDFS-12698) Ozone: Use time units in the Ozone configuration values
Date Fri, 01 Dec 2017 20:00:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274862#comment-16274862
] 

Anu Engineer edited comment on HDFS-12698 at 12/1/17 7:59 PM:
--------------------------------------------------------------

[~elek] Sorry, I just cross-checked and it seems that these tests are still using the old
code in patch 8.

https://issues.apache.org/jira/browse/HDFS-12698?focusedCommentId=16269268&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16269268

Can you please address those code review comments in the above link?


was (Author: anu):
+1, There are few checkstyle issues (mostly line length), I will fix them while committing.

> Ozone: Use time units in the Ozone configuration values
> -------------------------------------------------------
>
>                 Key: HDFS-12698
>                 URL: https://issues.apache.org/jira/browse/HDFS-12698
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Elek, Marton
>            Assignee: Elek, Marton
>         Attachments: HDFS-12698-HDFS-7240.001.patch, HDFS-12698-HDFS-7240.002.patch,
HDFS-12698-HDFS-7240.003.patch, HDFS-12698-HDFS-7240.005.patch, HDFS-12698-HDFS-7240.006.patch,
HDFS-12698-HDFS-7240.007.patch, HDFS-12698-HDFS-7240.008.patch
>
>
> In HDFS-9847 introduced a new way to configure the time related configuration with using
time unit in the vaule (eg. 10s, 5m, ...).
> Because the new behavior I have seen a lot of warning during my tests:
> {code}
> 2017-10-19 18:35:19,955 [main] INFO  Configuration.deprecation (Configuration.java:logDeprecation(1306))
- No unit for scm.container.client.idle.threshold(10000) assuming MILLISECONDS
> {code}
> So we need to add the time unit for every configuration. Unfortunately we have a few
configuration parameter which includes the unit in the key name (eg dfs.cblock.block.buffer.flush.interval.seconds
or ozone.container.report.interval.ms).
> I suggest to remove all the units from the key name and follow the new convention where
any of the units could be used. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message