Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9B243200D33 for ; Wed, 8 Nov 2017 12:48:06 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 99A4D160BE0; Wed, 8 Nov 2017 11:48:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DE4DB160BDA for ; Wed, 8 Nov 2017 12:48:05 +0100 (CET) Received: (qmail 60221 invoked by uid 500); 8 Nov 2017 11:48:05 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 60210 invoked by uid 99); 8 Nov 2017 11:48:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Nov 2017 11:48:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 48F811807DC for ; Wed, 8 Nov 2017 11:48:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 5NWA0W2mIwSR for ; Wed, 8 Nov 2017 11:48:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 66CFD5FC1C for ; Wed, 8 Nov 2017 11:48:03 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9D471E0E7A for ; Wed, 8 Nov 2017 11:48:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3779C241A0 for ; Wed, 8 Nov 2017 11:48:01 +0000 (UTC) Date: Wed, 8 Nov 2017 11:48:01 +0000 (UTC) From: "Mukul Kumar Singh (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-12739) Add Support for SCM --init command MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 08 Nov 2017 11:48:06 -0000 [ https://issues.apache.org/jira/browse/HDFS-12739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243778#comment-16243778 ] Mukul Kumar Singh commented on HDFS-12739: ------------------------------------------ Thanks for the updated patch [~shashikant], the latest patch is almost ready. Some very small minor comments. Rest Looks good to me after these changes are done. 1) Storage.java: Please change the logging to sl4j in place to apache.commons. 2) Storage.java:106, extra space between long and getCreationTime 3) StorageContainerManager:396, set the exit code before returning 4) StorageInfo.java: Please change the logging to sl4j in place to apache.commons. 5) readFrom, can use try with resources block as in the write function > Add Support for SCM --init command > ---------------------------------- > > Key: HDFS-12739 > URL: https://issues.apache.org/jira/browse/HDFS-12739 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: HDFS-7240 > Affects Versions: HDFS-7240 > Reporter: Shashikant Banerjee > Assignee: Shashikant Banerjee > Attachments: HDFS-12739-HDFS-7240.001.patch, HDFS-12739-HDFS-7240.002.patch, HDFS-12739-HDFS-7240.003.patch, HDFS-12739-HDFS-7240.004.patch, HDFS-12739-HDFS-7240.005.patch, HDFS-12739-HDFS-7240.006.patch, HDFS-12739-HDFS-7240.007.patch, HDFS-12739-HDFS-7240.008.patch > > > SCM --init command will generate cluster ID and persist it locally. The same cluster Id will be shared with KSM and the datanodes. IF the cluster Id is already available in the locally available version file, it will just read the cluster Id . -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org