hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharat Viswanadham (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12808) Add LOG.isDebugEnabled() guard for LOG.debug("...")
Date Wed, 29 Nov 2017 18:22:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271287#comment-16271287
] 

Bharat Viswanadham commented on HDFS-12808:
-------------------------------------------

[~busbey]
Is it fine to address only this in this jira, for rest I have created HDFS-12829.

> Add LOG.isDebugEnabled() guard for LOG.debug("...")
> ---------------------------------------------------
>
>                 Key: HDFS-12808
>                 URL: https://issues.apache.org/jira/browse/HDFS-12808
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Mehran Hassani
>            Assignee: Bharat Viswanadham
>            Priority: Minor
>         Attachments: HDFS-12808.00.patch, HDFS-12808.01.patch
>
>
> I am conducting research on log related bugs. I tried to make a tool to fix repetitive
yet simple patterns of bugs that are related to logs. In this file, there is a debug level
logging statement containing multiple string concatenation without the if statement before
them: 
> hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestCachingStrategy.java,
LOG.debug("got fadvise(offset=" + offset + ", len=" + len +",flags=" + flags + ")");, 82
> Would you be interested in adding the if,  to the logging statement?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message