hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiaoyu Yao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12805) Ozone: Redundant characters printed in exception log
Date Mon, 13 Nov 2017 20:36:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16250196#comment-16250196
] 

Xiaoyu Yao commented on HDFS-12805:
-----------------------------------

Thanks [~linyiqun] for reporting the issue and posting the patch. 
I just have a question about the fix: why not removing the parameter {} and use  {{Logger.error(String
msg, Throwable t)}} directly?

> Ozone: Redundant characters printed in exception log
> ----------------------------------------------------
>
>                 Key: HDFS-12805
>                 URL: https://issues.apache.org/jira/browse/HDFS-12805
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Yiqun Lin
>            Assignee: Yiqun Lin
>            Priority: Minor
>              Labels: newbie
>         Attachments: HDFS-12805-HDFS-7240.001.patch
>
>
> Found some incorrect usage of sl4j in class {{Volume/Bucket/KeyProcessTemplate.class}}.
> For Example line100 in {{VolumeProcessTemplate#handleCall(}},
> We use {{LOG.error("illegal argument. {}", ex);}} to print error info. It will invoke
{{Logger.error(String msg, Throwable t)}} not {{Logger.debug(String format, Object arg1)}}.
> Redundant characters '{}' will be printed in exception log.
> The correct usage of this should be {{LOG.error("illegal argument. {}", ex.toString());}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message