hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12804) Use slf4j instead of log4j in FSEditLog
Date Mon, 13 Nov 2017 19:24:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16250034#comment-16250034
] 

Arpit Agarwal commented on HDFS-12804:
--------------------------------------

Hi [~msingh], this change looks unnecessary. 
{code}
-        LOG.error(e);
+        LOG.error("Exception while selecting input streams" + e);
{code}
Perhaps {{LOG.error("Exception while selecting input streams", e)}} will be better so we retain
the call stack.

> Use slf4j instead of log4j in FSEditLog
> ---------------------------------------
>
>                 Key: HDFS-12804
>                 URL: https://issues.apache.org/jira/browse/HDFS-12804
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs
>            Reporter: Mukul Kumar Singh
>            Assignee: Mukul Kumar Singh
>         Attachments: HDFS-12804.001.patch, HDFS-12804.002.patch
>
>
> FSEditLog uses log4j, this jira will update the logging to use sl4j.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message