hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiaoyu Yao (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HDFS-12786) Ozone: add port/service names to the ksm/scm web ui
Date Mon, 20 Nov 2017 21:21:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16257815#comment-16257815
] 

Xiaoyu Yao edited comment on HDFS-12786 at 11/20/17 9:20 PM:
-------------------------------------------------------------

[~elek], thanks for reporting the issue and posting the fix. 
The change looks good to me. Can we remove the ":" before the port number? Otherwise, +1.



was (Author: xyao):
[~elek], thanks for reporting the issue and posting the fix. 
It looks good to me and I only have one question: do we need to export serverName from the
ksm/scm UI(e.g., ksm.js or scm.js) so that the tag.serverName referred in ozone.js is not
null or empty?

> Ozone: add port/service names to the ksm/scm web ui
> ---------------------------------------------------
>
>                 Key: HDFS-12786
>                 URL: https://issues.apache.org/jira/browse/HDFS-12786
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Elek, Marton
>            Assignee: Elek, Marton
>            Priority: Minor
>         Attachments: HDFS-12786-HDFS-7240.001.patch
>
>
> Since HDFS-12655 an additional serviceNames field is available for all rpc service via
the metrics interface.
> This super small patch modifies to scm/ksm web ui to display this name.
> Instead of
> :9863
> We will display:
> ScmBlockLocationProtocolService (:9863)
> TESTING:
> Start dozone cluster and check the header of the rpc metrics section on the web ui: http://localhost:9876/



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message