hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anu Engineer (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HDFS-12734) Ozone: generate version specific documentation during the build
Date Fri, 03 Nov 2017 22:20:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238486#comment-16238486
] 

Anu Engineer edited comment on HDFS-12734 at 11/3/17 10:19 PM:
---------------------------------------------------------------

bq.the requirements that we place on end users trying to build Hadoop. Every additional dependency
just makes it that much harder.

This patch already skips the Hugo based path if the user does not have it, so the user is
not burdened by it or have zero impact other than not having this optional feature in the
UI. The only thing this patch does is that it adds hugo automatically in case of Jenkins builds,
It just makes it easy for us when we do releases. 

I do agree that we should document this in BUILDING.txt as an optional dependency if someone
wants to get that feature.

bq. Why does it need to be hugo-based?

As I said already, I was genuinely trying to reduce the dependency on Web UI tools. I used
whatever was being proposed as the tool for next generation of  Hadoop website. I sincerely
thought I was trying to reduce the confusion by using the next set of tools that Hadoop seem
to take dependency upon. As I said, this is an optional feature, not having this tool in the
path will not even cause a build issue.


was (Author: anu):
bq.the requirements that we place on end users trying to build Hadoop. Every additional dependency
just makes it that much harder.

This patch already skips the Hugo based path if the user does not have it, so the user is
not burdened by it or have zero impact other than not having this optional feature in the
UI. The only thing this patch does it add that automatically in case of Jenkins builds, It
just makes it easy for us when we do releases. 

I do agree that we should document this in BUILDING.txt as an optional dependency if someone
wants to get that feature.

bq. Why does it need to be hugo-based?

As I said already, I was genuinely trying to reduce the dependency on Web UI tools. I used
whatever was being proposed as the tool for next generation of  Hadoop website. I sincerely
thought I was trying to reduce the confusion by using the next set of tools that Hadoop seem
to take dependency upon. As I said, this is an optional feature, not having this tool in the
path will not even cause a build issue.

> Ozone: generate version specific documentation during the build
> ---------------------------------------------------------------
>
>                 Key: HDFS-12734
>                 URL: https://issues.apache.org/jira/browse/HDFS-12734
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Elek, Marton
>            Assignee: Elek, Marton
>            Priority: Major
>         Attachments: HDFS-12734-HDFS-7240.001.patch
>
>
> HDFS-12664 susggested a new way to include documentation in the KSM web ui.
> This patch modifies the build lifecycle to automatically generate the documentation *if*
hugo is on the PATH. If hugo is not there  the documentation won't be generated and it won't
be displayed (see HDFS-12661)
> To test: Apply this patch on top of HDFS-12664 do a full build and check the KSM webui.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message