hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nanda kumar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12549) Ozone: OzoneClient: Support for REST protocol
Date Wed, 08 Nov 2017 18:58:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244543#comment-16244543

Nanda kumar commented on HDFS-12549:

[~xyao], review comments are addressed in patch v004.

bq. have you consider using the new JDK8 DateTimeFormatter/ZonedDateTime for the handling
of ozone creation/modification timestamp?
Thanks for the suggestion, I have modified it accordingly.

bq. Please add some comments to it and the default values for OZONE_REST_CLIENT_HTTP_CONNECTION_MAX
and maybe some document also in ozone-default.xml

bq. there are other configurations of PoolingHttpClientConnectionManager that we might want
to expose via OzoneConfigKeys in addition to the MaxTotal, e.g., max per route
Apart from MaxTotal also added DefaultMaxPerRoute, please let me know if anything else needs
to be added.

bq. we don't need to instantiate a new data formatter here. The hard coded format string can
be replaced by OzoneConsts.OZONE_DATE_FORMAT.

bq. should use the getShortUserName()

bq. executeHttpRequest does not close the response, which causes leaking of the response stream.

Since in {{createKey}} and {{getKey}} the {{HttpEntity}} has to be close only when we close
the stream, the responsibility of consuming response HttpEntity is given to the caller. I
have updated the javadoc to make it explicit to the caller of {{executeHttpRequest}}

> Ozone: OzoneClient: Support for REST protocol
> ---------------------------------------------
>                 Key: HDFS-12549
>                 URL: https://issues.apache.org/jira/browse/HDFS-12549
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>            Reporter: Nanda kumar
>            Assignee: Nanda kumar
>         Attachments: HDFS-12549-HDFS-7240.000.patch, HDFS-12549-HDFS-7240.001.patch,
HDFS-12549-HDFS-7240.002.patch, HDFS-12549-HDFS-7240.003.patch, HDFS-12549-HDFS-7240.004.patch
> Support for REST protocol in OzoneClient. 

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message