Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 30 Oct 2017 18:35:00 +0000 (UTC)
From: "Tsz Wo Nicholas Sze (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.13112381.1509046180000.102732.1509388500762@Atlassian.JIRA>
In-Reply-To: <JIRA.13112381.1509046180000@Atlassian.JIRA>
References: <JIRA.13112381.1509046180000@Atlassian.JIRA> <JIRA.13112381.1509046180796@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HDFS-12720) Ozone: Ratis options are not passed
 from KSM Client protobuf helper correctly.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 30 Oct 2017 18:35:05 -0000


    [ https://issues.apache.org/jira/browse/HDFS-12720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225504#comment-16225504 ] 

Tsz Wo Nicholas Sze commented on HDFS-12720:
--------------------------------------------

Patch looks good.  Just some minor comments:

- Should the code below be channel().close().sync()?
{code}
//XceiverClient.close
      try {
        channelFuture.channel().closeFuture().sync();
      } catch (InterruptedException ie) {
        LOG.error("close for pipeline:{} interrupted", pipeline, ie);
      }
{code}
-* Also, the ie won't be printed to LOG.  It should be chanaged to:
{code}
        LOG.warn("close for pipeline: " + pipeline + " interrupted", ie);
{code}
-* Since the ie is ignored, let's use warn instead of error.

- Let's add a newRaftGroup(datanodes) to RatisHelper
{code}
  static <E extends DatanodeID> RaftGroup newRaftGroup(List<E> datanodes) {
    return newRaftGroup(toRaftPeers(datanodes));
  }
{code}
so that we can use it in XceiverClientRatis
{code}
  public void createPipeline(String clusterId, List<DatanodeID> datanodes)
      throws IOException {
    final RaftGroup group = RatisHelper.newRaftGroup(datanodes);
    LOG.debug("initializing pipeline:{} with nodes:{}", clusterId, group.getPeers());
    reinitialize(datanodes, group);
  }
{code}


> Ozone: Ratis options are not passed from KSM Client protobuf helper correctly.
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-12720
>                 URL: https://issues.apache.org/jira/browse/HDFS-12720
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Mukul Kumar Singh
>            Assignee: Mukul Kumar Singh
>              Labels: ozoneMerge
>             Fix For: HDFS-7240
>
>         Attachments: HDFS-12720-HDFS-7240.001.patch, HDFS-12720-HDFS-7240.002.patch, HDFS-12720-HDFS-7240.003.patch
>
>
> {{KeySpaceManagerProtocolClientSideTranslatorPB#allocateBlock}} and {{KeySpaceManagerProtocolClientSideTranslatorPB#openKey}} do not pass the ratis replication factor and replication type to the KSM server. this causes the allocations using ratis model to resort to standalone mode even when Ratis mode is specified.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org