hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shashikant Banerjee (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12742) Add support for KSM --expunge command
Date Mon, 30 Oct 2017 11:17:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16224719#comment-16224719
] 

Shashikant Banerjee commented on HDFS-12742:
--------------------------------------------

Hi [~cheersyang],

Thanks for the review comments. In the patch, in file KSMExpunge.java: line 100
  List<BlockGroup> keyBlocksList =
            keyManager.getDeletionKeys(keyLimitPerTask);


This will read all the keys (both normal as well keys suffixed with #deleting) and send deletion
request to SCM. The code is very similar to keyDeletingService.java in KSM, the only change
introduced is to read all the keys not just the deleted keys in KSM db and then delete the
key. Since the code is very similar in both the cases, i will restructure the code for reusability.
I will add few test cases as well so as to verify the same.

Please let me know if i am missing out something here.


> Add support for KSM --expunge command
> -------------------------------------
>
>                 Key: HDFS-12742
>                 URL: https://issues.apache.org/jira/browse/HDFS-12742
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: HDFS-7240
>            Reporter: Shashikant Banerjee
>            Assignee: Shashikant Banerjee
>             Fix For: HDFS-7240
>
>         Attachments: HDFS-12742-HDFS-7240.001.patch, HDFS-12742-HDFS-7240.002.patch
>
>
> KSM --expunge will delete all the data from the data nodes for all the keys in the KSM
db. 
> User will have no control over the deletion.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message