hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chen Liang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12583) Ozone: Fix swallow exceptions which makes hard to debug failures
Date Tue, 03 Oct 2017 18:47:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190134#comment-16190134
] 

Chen Liang commented on HDFS-12583:
-----------------------------------

Thanks [~linyiqun] for reporting this! We do need to improve logging on certain places. Could
you please elaborate a bit on how you got the error in the description? Agree with Weiwei
on that one key thing is we'd better be sure that no exceptions get logged more than once.

Also some comments:
1.BucketProcessTemplate logs the original IOException {{fsExp}} at the beginning of {{handleIOException}},
but {{handleIOException}} in {{VolumeProcessTemplate}} logs the transformed OzoneException
at the end.
2. Seems the patch only handles IOException? Because there are other exception, such as IllegalArgumentException
in VolumeProcessTemplate#handle that are still logged in debug.

> Ozone: Fix swallow exceptions which makes hard to debug failures
> ----------------------------------------------------------------
>
>                 Key: HDFS-12583
>                 URL: https://issues.apache.org/jira/browse/HDFS-12583
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Yiqun Lin
>            Assignee: Yiqun Lin
>              Labels: ozoneMerge
>         Attachments: HDFS-12583-HDFS-7240.001.patch, HDFS-12583-HDFS-7240.002.patch
>
>
> There are some places that swallow exceptions that makes client hard to debug the failure.
For example, if we get xceiver client from xceiver client manager error, client only gets
the error info like this:
> {noformat}
> org.apache.hadoop.ozone.web.exceptions.OzoneException: Exception getting XceiverClient.
> 	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
> 	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> 	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> 	at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> 	at com.fasterxml.jackson.databind.introspect.AnnotatedConstructor.call(AnnotatedConstructor.java:119)
> 	at com.fasterxml.jackson.databind.deser.std.StdValueInstantiator.createUsingDefault(StdValueInstantiator.java:243)
> {noformat}
> The error exception stack is missing. We should print the error log as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message