hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiaoyu Yao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12568) Ozone: Cleanup the ozone-default.xml
Date Mon, 02 Oct 2017 22:51:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188994#comment-16188994

Xiaoyu Yao commented on HDFS-12568:

The patch looks excellent to me. I just have few NITs in ozone-default.xml. 

Lin 126: can we change to dfs.cblock.container.size.gb to be consistent with other Ozone keys
related to size.
Line 138/251: Should we use ${hadoop.tmp.dir}/cblockCacheDB?
Line 327: should we add a CONTAINER tag for dfs.container.ipc.random.port?
Line 337: should we add a RATIS tag for dfs.container.ratis.datanode.storage.dir?
Line 448: NIT: can you add xml comment to mark the beginning of the CLIENT related keys?

> Ozone: Cleanup the ozone-default.xml
> ------------------------------------
>                 Key: HDFS-12568
>                 URL: https://issues.apache.org/jira/browse/HDFS-12568
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>            Priority: Blocker
>              Labels: ozoneMerge
>         Attachments: HDFS-12568-HDFS-7240.001.patch, HDFS-12568-HDFS-7240.002.patch,
> This JIRA proposes to clean up the ozone-default.xml before the merge.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message