hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wei Yan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12502) nntop should support a category based on FilesInGetListingOps
Date Fri, 13 Oct 2017 17:49:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16203925#comment-16203925
] 

Wei Yan commented on HDFS-12502:
--------------------------------

LGTM. One minor format:
{code}
     verify(rb, times(3)).addCounter(Interns.info("op=listStatus." +
         "user=test.count", "Total operations performed by user"), 3L);
+
+    verify(rb, times(3)).addCounter(Interns.info("op=" + FILES_IN_GETLISTING +
+            ".user=test.count", "Total operations performed by user"), 1000L);
   }
{code}
some extra spaces there in the last line change.

> nntop should support a category based on FilesInGetListingOps
> -------------------------------------------------------------
>
>                 Key: HDFS-12502
>                 URL: https://issues.apache.org/jira/browse/HDFS-12502
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: metrics
>            Reporter: Zhe Zhang
>            Assignee: Zhe Zhang
>         Attachments: HDFS-12502.00.patch, HDFS-12502.01.patch, HDFS-12502.02.patch, HDFS-12502.03.patch
>
>
> Large listing ops can oftentimes be the main contributor to NameNode slowness. The aggregate
cost of listing ops is proportional to the {{FilesInGetListingOps}} rather than the number
of listing ops. Therefore it'd be very useful for nntop to support this category.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message