hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiao Chen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12482) Provide a configuration to adjust the weight of EC recovery tasks to adjust the speed of recovery
Date Wed, 25 Oct 2017 05:56:02 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218148#comment-16218148
] 

Xiao Chen commented on HDFS-12482:
----------------------------------

Thanks for the new rev Eddy!

We can use preconditions which will conveniently throw a {{IllegalArgumentException}} for
invalid arguments, so we don't have to change the constructor signature.
{code}
    Preconditions.checkArgument(this.xmitWeight >= 0,
        "Invalid value configured for "
            + DFSConfigKeys.DFS_DN_EC_RECONSTRUCTION_XMITS_WEIGHT_KEY
            + ", it can not be negative value (" + this.xmitWeight + ").");
{code}

+1 once this is done and checkstyle unused imports are fixed.

> Provide a configuration to adjust the weight of EC recovery tasks to adjust the speed
of recovery
> -------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-12482
>                 URL: https://issues.apache.org/jira/browse/HDFS-12482
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: erasure-coding
>    Affects Versions: 3.0.0-alpha4
>            Reporter: Lei (Eddy) Xu
>            Assignee: Lei (Eddy) Xu
>            Priority: Minor
>              Labels: hdfs-ec-3.0-nice-to-have
>         Attachments: HDFS-12482.00.patch, HDFS-12482.01.patch, HDFS-12482.02.patch, HDFS-12482.03.patch
>
>
> The relative speed of EC recovery comparing to 3x replica recovery is a function of (EC
codec, number of sources, NIC speed, and CPU speed, and etc). 
> Currently the EC recovery has a fixed {{xmitsInProgress}} of {{max(# of sources, # of
targets)}} comparing to {{1}} for 3x replica recovery, and NN uses {{xmitsInProgress}} to
decide how much recovery tasks to schedule to the DataNode this we can add a coefficient for
user to tune the weight of EC recovery tasks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message