[ https://issues.apache.org/jira/browse/HDFS-12474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16224827#comment-16224827
]
Yiqun Lin commented on HDFS-12474:
----------------------------------
Thanks for working on this, [~nandakumar131]. Some comments from me:
*ScmConfigKeys.java*:
line 230: Why not use {{float}} type value for the threshold-percentage setting? And use {{Configuation#getFloat}}
to get its value. The default value here can be showed as {{0.9f}}.
*ContainerMapping.java*:
line 375: {{(containerInfo.getUsed() / containerInfo.getSize())}} should be {{1.0 * (containerInfo.getUsed()
/ containerInfo.getSize())}}. The return type of getUsed and getSize are both {{long}} type.
*ContainerStateManager.java*:
line 369: {{ContainerInfo.lastUsed}} doesn't be set here.
Would you please also add additional unit test that verify the correctness of handling container
reports?
Current change of UT is just replacing the new class.
Thanks.
> Ozone: SCM: Handling container report with key count and container usage.
> -------------------------------------------------------------------------
>
> Key: HDFS-12474
> URL: https://issues.apache.org/jira/browse/HDFS-12474
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: HDFS-7240
> Reporter: Xiaoyu Yao
> Assignee: Nanda kumar
> Labels: ozoneMerge
> Attachments: HDFS-12474-HDFS-7240.000.patch
>
>
> Currently, the container report only contains the # of reports sent to SCM. We will need
to provide the key count and the usage of each individual containers to update the SCM container
state maintained by ContainerStateManager. This has a dependency on HDFS-12387.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org
|