hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daryn Sharp (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12396) Webhdfs file system should get delegation token from kms provider.
Date Wed, 18 Oct 2017 14:46:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209463#comment-16209463
] 

Daryn Sharp commented on HDFS-12396:
------------------------------------

In {{KMSUtil}}, I'm not fond of returning null when passed null.  In general, it bothers me
to see methods short out and return null for what would/should be invalid input.  It tends
to create landmines for other changes and/or mask bugs.  It's the caller's responsibility
to decide to invoke a method, and the method should do exactly what it's designed to do.

The moved/new methods seem like they should be in {{KMSUtil}}, rather than {{DFSUtilClient}},
with private/unstable annotations in case we need to make further modifications.

Minor, {{KeyProviderHelper}} is rather generic and doesn't convey what it does.  I'd consider
something more like {{KeyProviderTokenAdapter}}, {{KeyProviderTokenIssuer}}, etc.

Does {{WebHdfsFileSystem#keyProvider}} really need to exist and only be set for tests?  Could
a spy be used instead?

> Webhdfs file system should get delegation token from kms provider.
> ------------------------------------------------------------------
>
>                 Key: HDFS-12396
>                 URL: https://issues.apache.org/jira/browse/HDFS-12396
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: encryption, kms, webhdfs
>            Reporter: Rushabh S Shah
>            Assignee: Rushabh S Shah
>         Attachments: HDFS-12396.001.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message