hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rushabh S Shah (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-12396) Webhdfs file system should get delegation token from kms provider.
Date Fri, 20 Oct 2017 22:59:00 GMT

     [ https://issues.apache.org/jira/browse/HDFS-12396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Rushabh S Shah updated HDFS-12396:
    Attachment: HDFS-12396.002.patch

Attached a new patch.
bq. In KMSUtil, I'm not fond of returning null when passed null
Null is not an invalid input. If EZ is not enabled, this will be null.

The moved/new methods seem like they should be in KMSUtil, rather than DFSUtilClient, with
private/unstable annotations in case we need to make further modifications.
Added. After moving all the methods from {{hadoop-hdfs-client}} to {{hadoop-common}}, I also
needed to move {{UnknownCipherSuiteException.java}} from {{hadoop-hdfs-project/hadoop-hdfs-client}}
to {{hadoop-common-project/hadoop-common}}. I think nothing should break.

Minor, KeyProviderHelper is rather generic and doesn't convey what it does. I'd consider something
more like KeyProviderTokenAdapter, KeyProviderTokenIssuer, etc.

Does WebHdfsFileSystem#keyProvider really need to exist and only be set for tests? Could a
spy be used instead?
Please review.

> Webhdfs file system should get delegation token from kms provider.
> ------------------------------------------------------------------
>                 Key: HDFS-12396
>                 URL: https://issues.apache.org/jira/browse/HDFS-12396
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: encryption, kms, webhdfs
>            Reporter: Rushabh S Shah
>            Assignee: Rushabh S Shah
>         Attachments: HDFS-12396.001.patch, HDFS-12396.002.patch

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message