hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Virajith Jalaparti (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HDFS-11902) [READ] Merge BlockFormatProvider and FileRegionProvider.
Date Wed, 04 Oct 2017 23:51:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192211#comment-16192211
] 

Virajith Jalaparti edited comment on HDFS-11902 at 10/4/17 11:50 PM:
---------------------------------------------------------------------

Posting a new patch that in addition to the earlier changes contains the following changes:
(a) Merges BlockFormat and BlockProvider as BlockFormat anyway contains most of the functionality
(b) Renames BlockFormat as BlockAliasMap; the implementations of BlockFormat and the associated
configuration parameters are renamed appropriately.

These changes are based on the following feedback from [~ehiggs] and [~KasperJanssens]:
bq. "What is the objective of the BlockFormat, BlockProvider and BlockFormatProvider classes.
BlockFormatProvider implements BlockProvider and composes a BlockFormat. A lot of the calls
on BlockFormatProvider are just dispatched through to the BlockFormat, which makes BlockProvider
and BlockFormat have very very similar interfaces. It looks like they can all be replaced
with one interface, largely. They give rise to lots of extra classes, like an implementation
of BlockFormatProvider for the csv file and an implementation of BlockFormat for the csv file,
which dispatch to each other and look like they can all be done in one interface implementation
which will stay a lot smaller in scope than most of the other classes and will make it far
easier to see what’s going on."


was (Author: virajith):
Posting a new patch that in addition to the earlier changes contains the following changes:
(a) Merges BlockFormat and BlockProvider as BlockFormat anyway contains most of the functionality
(b) Renames BlockFormat as BlockAliasMap; the implementations of BlockFormat and the associated
configuration parameters are renamed appropriately.

> [READ] Merge BlockFormatProvider and FileRegionProvider.
> --------------------------------------------------------
>
>                 Key: HDFS-11902
>                 URL: https://issues.apache.org/jira/browse/HDFS-11902
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Virajith Jalaparti
>            Assignee: Virajith Jalaparti
>         Attachments: HDFS-11902-HDFS-9806.001.patch, HDFS-11902-HDFS-9806.002.patch,
HDFS-11902-HDFS-9806.003.patch, HDFS-11902-HDFS-9806.004.patch, HDFS-11902-HDFS-9806.005.patch,
HDFS-11902-HDFS-9806.006.patch, HDFS-11902-HDFS-9806.007.patch
>
>
> Currently {{BlockFormatProvider}} and {{TextFileRegionProvider}} perform almost the same
function on the Namenode and Datanode respectively. This JIRA is to merge them into one.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message