hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yiqun Lin (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HDFS-11468) Ozone: SCM: Add Node Metrics for SCM
Date Thu, 19 Oct 2017 09:28:01 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210765#comment-16210765
] 

Yiqun Lin edited comment on HDFS-11468 at 10/19/17 9:27 AM:
------------------------------------------------------------

Thanks for the response, [~cheersyang].
I am thinking for this again . I will update the metric name for container stat metrics.

bq. These are SCM level metrics right? Is it a bit overlapping with SCMMXBean?
Yes, it looks node metrics in SCMMetrics has some overlapping with SCMMXBean. I looked into
two similar classes NameNodeMXBean and NameNodeMetrics. The node count info is intended showed
in Jmx interface rather than as metrics. So I'd like to remove node metrics and only keep
container stat metrics in class SCMMetrics. But I insist on one point that we should kepp
these two classes alone and not merge all metrics. That is mean the info exposed in *Metrics
and *MXBean is a little different, like we have KSMMetrics and KSMMxBean, NameNodeMetrics
and NameNodeMXBean.
Does it looks good to you now, [~cheersyang]?
Will attach the new patch after your response.


was (Author: linyiqun):
Thanks for the response, [~cheersyang].
I am thinking for this again . I will update the metric name for container stat metrics.

bq. These are SCM level metrics right? Is it a bit overlapping with SCMMXBean?
Yes, it looks node metrics in SCMMetrics has some overlapping with SCMMXBean. I looked into
two similar classes NameNodeMXBean and NameNodeMetrics. The node count info is intended showed
in Jmx interface rather than as metrics. So I'd like to remove node metrics and only keep
container stat metrics in class SCMMetrics. But I insist on one point that we should kepp
these two classes alone and not merge all metrics. That is mean the info exposed in *Metrics
and *MXBean is a little different, like we have KSMMetrics and KSMMxBean, NameNodeMetrics
and NameNodeMXBean.
Does it looks good to you now, [~cheersyang]?

> Ozone: SCM: Add Node Metrics for SCM
> ------------------------------------
>
>                 Key: HDFS-11468
>                 URL: https://issues.apache.org/jira/browse/HDFS-11468
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>            Reporter: Xiaoyu Yao
>            Assignee: Yiqun Lin
>            Priority: Critical
>              Labels: OzonePostMerge
>         Attachments: HDFS-11468-HDFS-7240.001.patch, HDFS-11468-HDFS-7240.002.patch,
HDFS-11468-HDFS-7240.003.patch
>
>
> This ticket is opened to add node metrics in SCM based on heartbeat, node report and
container report from datanodes. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message