hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ewan Higgs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11045) TestDirectoryScanner#testThrottling fails: Throttle is too permissive
Date Tue, 10 Oct 2017 13:52:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198703#comment-16198703
] 

Ewan Higgs commented on HDFS-11045:
-----------------------------------

[~daniel@cloudera.com], can you rebase this?

{quote} Karthik Kambatla just pointed out an alternative I should have thought of a long time
ago: don't actually run the scanner. It looks like I should be able to easily take the ReportCompiler
out of context and test it on its own.{quote}
Indeed, if you're trying to test the throttling sleep calculation then there should be a function
that receives some times and computes a sleep value. Then you pump it will all sorts of values
and verify that it calculated the correct amount of time to sleep.

If you want to test the throttling mechanism then I suggest wrapping {{Thread.sleep}} so it
can be mocked and then make sure it was called with the appropriate values.

> TestDirectoryScanner#testThrottling fails: Throttle is too permissive
> ---------------------------------------------------------------------
>
>                 Key: HDFS-11045
>                 URL: https://issues.apache.org/jira/browse/HDFS-11045
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>    Affects Versions: 3.0.0-alpha2
>            Reporter: John Zhuge
>            Assignee: Daniel Templeton
>            Priority: Minor
>              Labels: flaky-test
>         Attachments: HDFS-11045.001.patch, HDFS-11045.002.patch, HDFS-11045.003.patch,
HDFS-11045.004.patch, HDFS-11045.005.patch, HDFS-11045.006.patch, HDFS-11045.007.patch, HDFS-11045.008.patch,
HDFS-11045.009.patch
>
>
>   TestDirectoryScanner.testThrottling:709 Throttle is too permissive
> https://builds.apache.org/job/PreCommit-HDFS-Build/17259/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message