hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Mackrory (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-206) Support for head in FSShell
Date Mon, 30 Oct 2017 15:11:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225096#comment-16225096
] 

Sean Mackrory commented on HDFS-206:
------------------------------------

This looks pretty good to me. A couple of nitpicks:
* You're still documenting the -f option for head in USAGE, although none exists.
* We should have a finally \{\} to close the file. Unlikely to ever cause a problem in practice
here, but good practice and easy enough to fix right now.
It's been too long for me to see the last test results, but we'll check again when you upload
the next patch. Unless it was TestDFSShell failing I think it's extremely unlikely to be your
patch that broke something.

> Support for head in FSShell
> ---------------------------
>
>                 Key: HDFS-206
>                 URL: https://issues.apache.org/jira/browse/HDFS-206
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>            Reporter: Olga Natkovich
>            Assignee: Gabor Bota
>            Priority: Minor
>              Labels: newbie
>         Attachments: HDFS-206.001.patch, HDFS-206.002.patch
>
>
> For Pig project, we would like to integrate head and tail commands into our shell (Grunt).
I could find tail but not head command



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message