Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 14 Sep 2017 22:09:00 +0000 (UTC)
From: "Rushabh S Shah (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.13102055.1505335169000.117493.1505426940243@Atlassian.JIRA>
In-Reply-To: <JIRA.13102055.1505335169000@Atlassian.JIRA>
References: <JIRA.13102055.1505335169000@Atlassian.JIRA> <JIRA.13102055.1505335169027@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HDFS-12442)
 WebHdfsFileSystem#getFileBlockLocations will always return
 BlockLocation#corrupt as false
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 14 Sep 2017 22:09:05 -0000


    [ https://issues.apache.org/jira/browse/HDFS-12442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167031#comment-16167031 ] 

Rushabh S Shah commented on HDFS-12442:
---------------------------------------

Thanks [~cheersyang] for the review.
I don't know whether we would need this jira judging by the developments going on in HDFS-11156.
Lets wait and watch.

> WebHdfsFileSystem#getFileBlockLocations will always return BlockLocation#corrupt as false
> -----------------------------------------------------------------------------------------
>
>                 Key: HDFS-12442
>                 URL: https://issues.apache.org/jira/browse/HDFS-12442
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: webhdfs
>    Affects Versions: 2.9.0, 3.0.0-alpha2
>            Reporter: Rushabh S Shah
>            Assignee: Rushabh S Shah
>            Priority: Critical
>         Attachments: HDFS-12442-1.patch
>
>
> Was going through {{JsonUtilClient#toBlockLocation}} code.
> Below is the relevant code snippet.
> {code:title=JsonUtilClient.java|borderStyle=solid}
>  /** Convert a Json map to BlockLocation. **/
>   static BlockLocation toBlockLocation(Map<?, ?> m)
>       throws IOException{
>     ...
>     ...  
>     boolean corrupt = Boolean.
>         getBoolean(m.get("corrupt").toString());
>     ...
>     ...
>   }
> {code}
> According to java docs for {{Boolean#getBoolean}}
> {noformat}
> Returns true if and only if the system property named by the argument exists and is equal to the string "true". 
> {noformat}
> I assume, the map value for key {{corrupt}} will be populated with either {{true}} or {{false}}.
> On the client side, {{Boolean#getBoolean}} will look for system property for true or false.
> So it will always return false unless the system property is set for true or false.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org