Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5ACE9200D02 for ; Sat, 9 Sep 2017 01:12:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 594F7160FF8; Fri, 8 Sep 2017 23:12:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9F0B41609E0 for ; Sat, 9 Sep 2017 01:12:03 +0200 (CEST) Received: (qmail 25564 invoked by uid 500); 8 Sep 2017 23:12:02 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 25553 invoked by uid 99); 8 Sep 2017 23:12:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Sep 2017 23:12:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id E6B481A01D7 for ; Fri, 8 Sep 2017 23:12:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id AL2a4ziFMuGR for ; Fri, 8 Sep 2017 23:12:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id ED53E5FC84 for ; Fri, 8 Sep 2017 23:12:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 76FFDE0EDB for ; Fri, 8 Sep 2017 23:12:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 22FFE24143 for ; Fri, 8 Sep 2017 23:12:00 +0000 (UTC) Date: Fri, 8 Sep 2017 23:12:00 +0000 (UTC) From: "Lei (Eddy) Xu (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (HDFS-12412) Remove ErasureCodingWorker.stripedReadPool MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 08 Sep 2017 23:12:04 -0000 [ https://issues.apache.org/jira/browse/HDFS-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159488#comment-16159488 ] Lei (Eddy) Xu edited comment on HDFS-12412 at 9/8/17 11:11 PM: --------------------------------------------------------------- Ping [~drankye] [~Sammi] [~andrew.wang] what would you think? was (Author: eddyxu): Ping [~drankye] [~Sammi] [~andrew.wang] for the inputs. > Remove ErasureCodingWorker.stripedReadPool > ------------------------------------------ > > Key: HDFS-12412 > URL: https://issues.apache.org/jira/browse/HDFS-12412 > Project: Hadoop HDFS > Issue Type: Improvement > Components: erasure-coding > Affects Versions: 3.0.0-alpha3 > Reporter: Lei (Eddy) Xu > Assignee: Lei (Eddy) Xu > > In {{ErasureCodingWorker}}, it uses {{stripedReconstructionPool}} to schedule the EC recovery tasks, while uses {{stripedReadPool}} for the reader threads in each recovery task. We only need one of them to throttle the speed of recovery process, because each EC recovery task has a fix number of source readers (i.e., 3 for RS(3,2)). And because of the findings in HDFS-12044, the speed of EC recovery can be throttled by {{strippedReconstructionPool}} with {{xmitsInProgress}}. > Moreover, keeping {{stripedReadPool}} makes customer difficult to understand and calculate the right balance between {{dfs.datanode.ec.reconstruction.stripedread.threads}}, {{dfs.datanode.ec.reconstruction.stripedblock.threads.size}} and {{maxReplicationStreams}}. For example, a small {{stripread.threads}} (comparing to which {{reconstruction.threads.size}} implies), will unnecessarily limit the speed of recovery, which leads to larger MTTR. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org