Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1A7F8200D04 for ; Mon, 11 Sep 2017 21:33:05 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 18FA11609C4; Mon, 11 Sep 2017 19:33:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 603BD1609B7 for ; Mon, 11 Sep 2017 21:33:04 +0200 (CEST) Received: (qmail 36238 invoked by uid 500); 11 Sep 2017 19:33:02 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 36227 invoked by uid 99); 11 Sep 2017 19:33:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Sep 2017 19:33:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 9D4A11A4D93 for ; Mon, 11 Sep 2017 19:33:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id Fc-4N5WVd_Oc for ; Mon, 11 Sep 2017 19:33:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id CED9B5FC1C for ; Mon, 11 Sep 2017 19:33:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 667CCE06BF for ; Mon, 11 Sep 2017 19:33:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1F6182414B for ; Mon, 11 Sep 2017 19:33:00 +0000 (UTC) Date: Mon, 11 Sep 2017 19:33:00 +0000 (UTC) From: "Chris Douglas (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-11600) Refactor TestDFSStripedOutputStreamWithFailure test classes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 11 Sep 2017 19:33:05 -0000 [ https://issues.apache.org/jira/browse/HDFS-11600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16161842#comment-16161842 ] Chris Douglas commented on HDFS-11600: -------------------------------------- Attached a naive rebase of the original patch. [~arpitagarwal], could you take a look? > Refactor TestDFSStripedOutputStreamWithFailure test classes > ----------------------------------------------------------- > > Key: HDFS-11600 > URL: https://issues.apache.org/jira/browse/HDFS-11600 > Project: Hadoop HDFS > Issue Type: Improvement > Components: test > Affects Versions: 3.0.0-alpha2 > Reporter: Andrew Wang > Assignee: Elek, Marton > Priority: Minor > Attachments: HDFS-11600.002.patch, HDFS-11600-1.patch > > > TestDFSStripedOutputStreamWithFailure has a great number of subclasses. The tests are parameterized based on the name of these subclasses. > Seems like we could parameterize these tests with JUnit and then not need all these separate test classes. > Another note, the tests will randomly return instead of running the test. Using {{Assume}} instead would make it more clear in the test output that these tests were skipped. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org