Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 13 Sep 2017 00:19:00 +0000 (UTC)
From: "Lei (Eddy) Xu (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12778339.1425074321000.96971.1505261940823@Atlassian.JIRA>
In-Reply-To: <JIRA.12778339.1425074321000@Atlassian.JIRA>
References: <JIRA.12778339.1425074321000@Atlassian.JIRA> <JIRA.12778339.1425074321894@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HDFS-7859) Erasure Coding: Persist erasure
 coding policies in NameNode
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 13 Sep 2017 00:19:08 -0000


    [ https://issues.apache.org/jira/browse/HDFS-7859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163920#comment-16163920 ] 

Lei (Eddy) Xu commented on HDFS-7859:
-------------------------------------

Thanks for the updates, [~Sammi]. LGTM overall. +1 pending.

Some small issues:

{code}
// loadPolicy()
if (!CodecUtil.hasCodec(policy.getCodecName()) ||
   policy.getCellSize() > maxCellSize) {
   // If policy is not supported in current system, set the policy state to
   // DISABLED;
   policy.setState(ErasureCodingPolicyState.DISABLED);
}
{code}

Does it mean that user can still enable this policy later via {{enablePolicy()}}? It is not necessary to be addressed in this patch, but do we have a way to guard what policy can be enabled. 

> Erasure Coding: Persist erasure coding policies in NameNode
> -----------------------------------------------------------
>
>                 Key: HDFS-7859
>                 URL: https://issues.apache.org/jira/browse/HDFS-7859
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Kai Zheng
>            Assignee: SammiChen
>              Labels: hdfs-ec-3.0-must-do
>         Attachments: HDFS-7859.001.patch, HDFS-7859.002.patch, HDFS-7859.004.patch, HDFS-7859.005.patch, HDFS-7859.006.patch, HDFS-7859.007.patch, HDFS-7859.008.patch, HDFS-7859.009.patch, HDFS-7859.010.patch, HDFS-7859.011.patch, HDFS-7859.012.patch, HDFS-7859.013.patch, HDFS-7859.014.patch, HDFS-7859.015.patch, HDFS-7859.016.patch, HDFS-7859-HDFS-7285.002.patch, HDFS-7859-HDFS-7285.002.patch, HDFS-7859-HDFS-7285.003.patch
>
>
> In meetup discussion with [~zhz] and [~jingzhao], it's suggested that we persist EC schemas in NameNode centrally and reliably, so that EC zones can reference them by name efficiently.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org