hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nandakumar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12537) Ozone: Reduce key creation overhead in Corona
Date Fri, 29 Sep 2017 12:21:01 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16185746#comment-16185746
] 

Nandakumar commented on HDFS-12537:
-----------------------------------

Thanks [~ljain] for working on this. Some minor comments.

1. Do we really need a flag for {{optimizedWrites}}? we can have this as default behavior.
Since we are adding {{UUID.randomUUID()}} to the data it becomes unique. This randomness should
be enough for testing. We can remove that option and have it as default behavior, it will
make life of the user more simple.

2. +1 for [~anu]'s suggestion on having date and time of execution in json output.

3. Current json file name format is something like {{2017-09-29 17:25:15,717+0530}}, can we
change it to {{YYYYMMDDHHMMSS}}?

3. "HH:mm:ss,SSS" can be defined as static final variable.

4: line 734: null check has to be done on {{os}} before {{os.close()}}

> Ozone: Reduce key creation overhead in Corona
> ---------------------------------------------
>
>                 Key: HDFS-12537
>                 URL: https://issues.apache.org/jira/browse/HDFS-12537
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Lokesh Jain
>            Assignee: Lokesh Jain
>         Attachments: HDFS-12537-HDFS-7240.001.patch, HDFS-12537-HDFS-7240.002.patch
>
>
> Currently Corona creates random key values for each key. This creates a lot of overhead.
An option should be provided to use a single key value.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message