hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chen Liang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12467) Ozone: SCM: NodeManager should log when it comes out of chill mode
Date Mon, 18 Sep 2017 21:06:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170717#comment-16170717
] 

Chen Liang commented on HDFS-12467:
-----------------------------------

Thanks [~nandakumar131] for the follow-up! I was trying to see if there is a way to only make
use of {{inManualChillMode}} but didn't come up with a clean way.

So if it turns out to be necessary to have two chillMode status, then I think it's probably
better to:
1. rename the new {{chillMode}} flag to something like {{inStartupChillMode}} and have some
brief comments describing the purpose and the differences. 
2. in  getChillModeStatus() seems startup chill mode is checked after manual chill mode check
passed, so I think let's expand the manual chill mode message to include this info, i.e. line
315 add something like return "Out of startup chill mode, but in manual chill mode." + ...

3. I think we should track manual chillmode enter/exit as well, i.e. add log entries to {{forceExitChillMode}}
and {{forceEnterChillMode}}. Maybe also changing line 178 and line 724 to "Enter/Leaving startup
chill mode" (rather than just "chill mode").
4. how about using {{AtomicBoolean}} or synchronize on the methods?

> Ozone: SCM: NodeManager should log when it comes out of chill mode
> ------------------------------------------------------------------
>
>                 Key: HDFS-12467
>                 URL: https://issues.apache.org/jira/browse/HDFS-12467
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>            Reporter: Nandakumar
>            Assignee: Nandakumar
>            Priority: Minor
>         Attachments: HDFS-12467-HDFS-7240.000.patch, HDFS-12467-HDFS-7240.001.patch
>
>
> {{NodeManager}} should add a log message when it comes out of chill mode.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message