hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Kumar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12455) WebHDFS - ListStatus query does not provide any information about a folder's "snapshot enabled" status
Date Mon, 25 Sep 2017 20:54:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179751#comment-16179751
] 

Ajay Kumar commented on HDFS-12455:
-----------------------------------

[~anu], Thanks for review.
bq. nit : final boolean seBit --> rename as snBit ? I was not able to understand what se
stood for.
seBit stands for snapshotEnabledBit. Changed Wrapper name to  {{snapshotEnabledBit}} to avoid
confusion.
bq. Just wondering do we have to modify this if statement ? {{if (aBit || eBit || ecBit) }}
Yes,A hdfs directory might be snapshot enabled irrespective of other 3 flags. To simplify
the change i have updated the if condition as {{if (aBit || eBit || ecBit || seBit)}}
bq. I see that we have 14 params already to FileStatus constructor, but since these are bits,
would you consider adding a new param, or adding a new ctor that takes a set<boolean>
or add a FileStatus Builder? Any of those params will be consistent with the current code.
But please don't touch the current constructor.
Yes, current constructor already has too many parameters. To avoid modifying existing constructor
or adding new one i have added set function. i.e {{setSnapShotEnabledFlag(boolean)}} .Wanted
to minimize the change for this jira so didn't added builder initially. Let me know if i should
add builder as part of this jira itself?
bq. can you also re-write the
Updated the segment with else condition in patch v3.

> WebHDFS - ListStatus query does not provide any information about a folder's "snapshot
enabled" status
> ------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-12455
>                 URL: https://issues.apache.org/jira/browse/HDFS-12455
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Ajay Kumar
>            Assignee: Ajay Kumar
>         Attachments: HDFS-12455.01.patch, HDFS-12455.02.patch
>
>
> WebHDFS - ListStatus query does not provide any information about a folder's "snapshot
enabled" status. Since "ListStatus" lists other attributes it will be good to include this
attribute as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message