hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Huafeng Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12398) Use JUnit Paramaterized test suite in TestWriteReadStripedFile
Date Mon, 11 Sep 2017 02:15:02 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160561#comment-16160561
] 

Huafeng Wang commented on HDFS-12398:
-------------------------------------

Hi [~drankye], very thanks for your review.
{quote}
1. The current way of having many test methods are much better readable;
{quote}
It's true, I can add some comments on the parameters if you wish. But I think currently the
ec file names also can tell what the test is doing.
{quote}
2. It's also easier to debug if some of them are failed;
{quote}
It's also true and it's the limitation of junit Parameterized. 
{quote}
3. More important, every test case (contained in a test method) needs a brand new cluster
to start with;
{quote}
It's intended because in each test, it will randomly kill a datanode so start with a new cluster
is needed.
{quote}
4. Timeout can be fine-tuned for each test method in current way.
{quote}
It's not true, before the refactor, the timeout is controlled by
{code}
@Rule
public Timeout globalTimeout = new Timeout(300000)
{code}
which applies the same timeout to all test methods in a class. 


> Use JUnit Paramaterized test suite in TestWriteReadStripedFile
> --------------------------------------------------------------
>
>                 Key: HDFS-12398
>                 URL: https://issues.apache.org/jira/browse/HDFS-12398
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>            Reporter: Huafeng Wang
>            Assignee: Huafeng Wang
>            Priority: Trivial
>         Attachments: HDFS-12398.001.patch, HDFS-12398.002.patch
>
>
> The TestWriteReadStripedFile is basically doing the full product of file size with data
node failure or not. It's better to use JUnit Paramaterized test suite.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message