hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daryn Sharp (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12386) Add fsserver defaults call to WebhdfsFileSystem.
Date Thu, 21 Sep 2017 22:19:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16175560#comment-16175560
] 

Daryn Sharp commented on HDFS-12386:
------------------------------------

Rather minor comments:
* {{UNSUPPPORTEDEXSTR}}: Per the constant above it, it's typical for constants to have underscores.
* {{storagepolicyId}} should be camel-cased as storage*P*olicyId to be more consistent.  to
be even more consistent with the getter methods, I'd call it defaultStoragePolicyId.
* {{((Number) json.get("replication")).shortValue();}} will NPE if the map doesn't contain
the value.  Might want to add getShort to compliment getInt, or just call getInt and cast
to short.
* As findbugs complained about, encryptDataTransfer is undergoing a lot of boxing/unboxing.
 Just do the exists check and return the map.get since it will unbox to the primitive boolean,
or return default.
* Make serverDefaultsResponse a volatile.  While unlikely, an object can be viewed in another
thread with uninitialized fields.  Volatile reads are cheap enough.

> Add fsserver defaults call to WebhdfsFileSystem.
> ------------------------------------------------
>
>                 Key: HDFS-12386
>                 URL: https://issues.apache.org/jira/browse/HDFS-12386
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: webhdfs
>            Reporter: Rushabh S Shah
>            Assignee: Rushabh S Shah
>            Priority: Minor
>         Attachments: HDFS-12386-1.patch, HDFS-12386-2.patch, HDFS-12386-3.patch, HDFS-12386.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message