hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rushabh S Shah (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-12386) Add fsserver defaults call to WebhdfsFileSystem.
Date Tue, 19 Sep 2017 19:59:00 GMT

     [ https://issues.apache.org/jira/browse/HDFS-12386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Rushabh S Shah updated HDFS-12386:
    Attachment: HDFS-12386-2.patch

The FSNameSystem#serverDefaults is statically built to avoid unnecessary construction of the
object. It would be nice if the json-encoded string was cached to avoid unnecessary conversion
of a static object into a map and serializing into a string.
Addressed in latest patch (v2)

Not sure -1 is an appropriate value for missing parameters. I'd double check the PB defaults
for parity with hdfs.
For all the required fields, kept the default value as -1.
For all the optional fields, synced with protobuf default values.

Default checksum should probably be 0 (represents "none") instead of -1.
Actually in protobuf, the default value is 1.

Blindly casting relatively new fields like storage policy to a primitive type cause exceptions.
Added a containsKey check for {{encryptDataTransfer}} value.

In the test, it verifies the server defaults returned from hdfs and webhdfs are equal. It
doesn't verify that one of them actually matches the explicitly conf values set by the test.
Addressed in the latest patch (v2)

> Add fsserver defaults call to WebhdfsFileSystem.
> ------------------------------------------------
>                 Key: HDFS-12386
>                 URL: https://issues.apache.org/jira/browse/HDFS-12386
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: webhdfs
>            Reporter: Rushabh S Shah
>            Assignee: Rushabh S Shah
>            Priority: Minor
>         Attachments: HDFS-12386-1.patch, HDFS-12386-2.patch, HDFS-12386.patch

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message