hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12304) Remove unused parameter from FsDatasetImpl#addVolume
Date Mon, 25 Sep 2017 16:43:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179288#comment-16179288
] 

Hudson commented on HDFS-12304:
-------------------------------

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12965 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/12965/])
HDFS-12304. Remove unused parameter from FsDatasetImpl#addVolume. (aajisaka: rev 02e2a9b1152b0e144fcf43bec2fce26d8a6c6dbc)
* (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java


> Remove unused parameter from FsDatasetImpl#addVolume
> ----------------------------------------------------
>
>                 Key: HDFS-12304
>                 URL: https://issues.apache.org/jira/browse/HDFS-12304
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Chen Liang
>            Assignee: Chen Liang
>            Priority: Minor
>             Fix For: 3.0.0-beta1, 3.1.0
>
>         Attachments: HDFS-12304.001.patch
>
>
> FsDatasetImpl has this method
> {code}
>   private void addVolume(Collection<StorageLocation> dataLocations,
>       Storage.StorageDirectory sd) throws IOException
> {code}
> Parameter {{dataLocations}} was introduced in HDFS-6740, this variable was used to get
storage type info. But HDFS-10637 has changed the way of getting storage type in this method,
making dataLocations no longer being used at all here. We should probably remove dataLocations
for a cleaner interface.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message