hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira Ajisaka (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-12304) Remove unused parameter from FsDatasetImpl#addVolume
Date Mon, 25 Sep 2017 16:28:00 GMT

     [ https://issues.apache.org/jira/browse/HDFS-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Akira Ajisaka updated HDFS-12304:
---------------------------------
       Resolution: Fixed
     Hadoop Flags: Reviewed
    Fix Version/s: 3.1.0
                   3.0.0-beta1
           Status: Resolved  (was: Patch Available)

Committed this to trunk and branch-3.0. Thanks [~vagarychen] and [~jnp].

> Remove unused parameter from FsDatasetImpl#addVolume
> ----------------------------------------------------
>
>                 Key: HDFS-12304
>                 URL: https://issues.apache.org/jira/browse/HDFS-12304
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Chen Liang
>            Assignee: Chen Liang
>            Priority: Minor
>             Fix For: 3.0.0-beta1, 3.1.0
>
>         Attachments: HDFS-12304.001.patch
>
>
> FsDatasetImpl has this method
> {code}
>   private void addVolume(Collection<StorageLocation> dataLocations,
>       Storage.StorageDirectory sd) throws IOException
> {code}
> Parameter {{dataLocations}} was introduced in HDFS-6740, this variable was used to get
storage type info. But HDFS-10637 has changed the way of getting storage type in this method,
making dataLocations no longer being used at all here. We should probably remove dataLocations
for a cleaner interface.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message