hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chen Liang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12268) Ozone: Add metrics for pending storage container requests
Date Tue, 12 Sep 2017 20:36:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163613#comment-16163613
] 

Chen Liang commented on HDFS-12268:
-----------------------------------

Thanks [~linyiqun] for updating the patch!

A few more minor comments. Basically can we make the name methods consistent with the metric
name? Specifically:
1. can we rename methods incrContainerOpsMetrics and decrContainerOpsMetrics to incrPendingContainerOpsMetrics
and decrPendingContainerOpsMetrics
2. can we rename variable pendingOpsLatency to containerOpsLatency (because they are no longer
pending when their latencies are added)

+1 with this fixed.

> Ozone: Add metrics for pending storage container requests
> ---------------------------------------------------------
>
>                 Key: HDFS-12268
>                 URL: https://issues.apache.org/jira/browse/HDFS-12268
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Yiqun Lin
>            Assignee: Yiqun Lin
>              Labels: ozoneMerge
>         Attachments: HDFS-12268-HDFS-7240.001.patch, HDFS-12268-HDFS-7240.002.patch,
HDFS-12268-HDFS-7240.003.patch, HDFS-12268-HDFS-7240.004.patch, HDFS-12268-HDFS-7240.005.patch,
HDFS-12268-HDFS-7240.006.patch
>
>
>  As storage container async interface has been supported after HDFS-11580, we need to
keep an eye on the queue depth of pending container requests. It can help us better found
if there are some performance problems.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message