hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mukul Kumar Singh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12100) Ozone: KSM: Allocate key should honour volume quota if quota is set on the volume
Date Mon, 04 Sep 2017 09:19:02 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16152364#comment-16152364
] 

Mukul Kumar Singh commented on HDFS-12100:
------------------------------------------

Thanks for the patch [~ljain], the patch looks really good, Please find my comments as following.

1) DistributedOzoneHandler: Please initialize the default quota as part of the constructor
for DistributedOzoneHandler, and use the default values elsewhere.
2) KeyManagerImpl.java:156, {{volumeBuilder.getSizeInBytes()}} volume size has already been
fetched, we can use the volume size here.
3) KeyManagerImpl.java:159, & 237 - These ops should be added as part of the DB batch
op and added together.
4) Please add a OzoneQuota Unit of PB as well :)


> Ozone: KSM: Allocate key should honour volume quota if quota is set on the volume
> ---------------------------------------------------------------------------------
>
>                 Key: HDFS-12100
>                 URL: https://issues.apache.org/jira/browse/HDFS-12100
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Mukul Kumar Singh
>            Assignee: Lokesh Jain
>             Fix For: HDFS-7240
>
>         Attachments: HDFS-12100-HDFS-7240.001.patch, HDFS-12100-HDFS-7240.002.patch
>
>
> KeyManagerImpl#allocateKey currently does not check the volume quota before allocating
a key, this can cause the volume quota overrun.
> Volume quota needs to be check before allocating the key in the SCM.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message