hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiaoyu Yao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12000) Ozone: Container : Add key versioning support-1
Date Fri, 01 Sep 2017 21:21:01 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16151164#comment-16151164
] 

Xiaoyu Yao commented on HDFS-12000:
-----------------------------------

Thanks [~vagarychen] for working on this. The patch looks good to me overall. I just have
a few comments below.

KeySpaceManagerProtocol.proto
Line 237: should createVersion be optional?
Line 241: KeyLocationListVersioned -> KeyLocationList or KeyLocations
Line 252: can we add the latestVersion to the end? 

KeyManager.java
Line 32: Can you add more comments on the sequence of allocateBlock->write->commitBlock?
Line 42: "Give a request size, a key and a version" I did not find the version from the input
parameter. Can you clarify?

KeyManagerImpl.java
Line 115: should we use Time.monotonicNow()?
Line 173: NIT: keykey-> objectKey

ChunkgroupOutputStream.java
Line 281: Please file followup JIRAs for TODO

KsmKeyInfo.java
Line 41: should we use AtomicLong for latestVersion? 

Line 81: NIT: getLatestVersionList -> getLatestLocations, can we modify this function
to take version as parameter so that this can be reused later when versions other than latest
are fully supported.
Line 82: version -> location
Line 107: Can you add some javadoc on the latestversion update?
Since we only update the latestVersion at commit time, there could be multiple clients that
allocate blocks before 
the first commit is done. Once the first commit is done, all the allocate will be invalid
to commit due to the logic
between line 109-115.
 
KsmKeyLocationListVersioned.java
NIT: To be consistent with change in KsmKeyInfo, can we rename this to KsmKeyLocationList.java,
which always include version.



> Ozone: Container : Add key versioning support-1
> -----------------------------------------------
>
>                 Key: HDFS-12000
>                 URL: https://issues.apache.org/jira/browse/HDFS-12000
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Anu Engineer
>            Assignee: Chen Liang
>         Attachments: HDFS-12000-HDFS-7240.001.patch, HDFS-12000-HDFS-7240.002.patch,
HDFS-12000-HDFS-7240.003.patch, OzoneVersion.001.pdf
>
>
> The rest interface of ozone supports versioning of keys. This support comes from the
containers and how chunks are managed to support this feature. This JIRA tracks that feature.
Will post a detailed design doc so that we can talk about this feature.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message