hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Clampffer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11973) libhdfs++: Remove redundant directories in examples
Date Wed, 13 Sep 2017 15:26:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16164822#comment-16164822
] 

James Clampffer commented on HDFS-11973:
----------------------------------------

I like this patch.  I'm not +1 yet just because it seems to break incremental builds and I'd
like to see if there's a way to avoid that.  It looks like binary being generated has the
same name in the same location as a directory that used to be created when there was an extra
level of directories.  Any idea if there's a simple fix?

> libhdfs++: Remove redundant directories in examples
> ---------------------------------------------------
>
>                 Key: HDFS-11973
>                 URL: https://issues.apache.org/jira/browse/HDFS-11973
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: Anatoli Shein
>            Assignee: Anatoli Shein
>         Attachments: HDFS-11973.HDFS-8707.000.patch, HDFS-11973.HDFS-8707.001.patch,
HDFS-11973.HDFS-8707.002.patch
>
>
> In order to keep consistent with the tools and tests I think we should remove one level
of directories in examples folder. 
> E.g this directory:
> /hadoop-hdfs-native-client/src/main/native/libhdfspp/examples/c/cat/cat.c
> Should become this:
> /hadoop-hdfs-native-client/src/main/native/libhdfspp/examples/c/cat.c
> Removing the redundant directories will also simplify our cmake file maintenance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message