hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yiqun Lin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11676) Ozone: SCM CLI: Implement close container command
Date Mon, 11 Sep 2017 03:34:02 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160618#comment-16160618

Yiqun Lin commented on HDFS-11676:

Thanks for the working, [~vagarychen]. The initial patch looks good overall. Only two minor

line 27: {{Expecting container create}} should be {{Expecting container close}}.

line 293: I am thinking if we can use state machine, that seems better than directly update
the container state. There is already {{CLOSED}} state and corresponding event type defined
in state machine. After that, we can reuse {{Mapping#updateContainerState}} for updating the

In addition, can you help check this failure test {{hadoop.ozone.scm.node.TestNodeManager}}?
Please fix findbugs, ASF and checkstyle warning in your next patch. Thanks.

> Ozone: SCM CLI: Implement close container command
> -------------------------------------------------
>                 Key: HDFS-11676
>                 URL: https://issues.apache.org/jira/browse/HDFS-11676
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>            Reporter: Weiwei Yang
>            Assignee: Chen Liang
>              Labels: ozoneMerge, tocheck
>         Attachments: HDFS-11676-HDFS-7240.001.patch
> Implement close container command
> {code}
> hdfs scm -container close <container name>
> {code}
> This command connects to SCM and closes a container. Once the container is closed in
the SCM, the corresponding container is closed at the appropriate datanode. if the container
does not exist, it will return an error.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message