hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11600) Refactor TestDFSStripedOutputStreamWithFailure test classes
Date Mon, 11 Sep 2017 22:13:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162122#comment-16162122

Andrew Wang commented on HDFS-11600:

I posted an alternative disable patch on HDFS-12417.

I don't think we can do that much better when it comes to refactoring. We can parameterize
using JUnit instead of the classname and add better docs, but I don't know how to get around
having all these different test classes.

> Refactor TestDFSStripedOutputStreamWithFailure test classes
> -----------------------------------------------------------
>                 Key: HDFS-11600
>                 URL: https://issues.apache.org/jira/browse/HDFS-11600
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Andrew Wang
>            Assignee: Elek, Marton
>            Priority: Minor
>         Attachments: HDFS-11600.002.patch, HDFS-11600-1.patch
> TestDFSStripedOutputStreamWithFailure has a great number of subclasses. The tests are
parameterized based on the name of these subclasses.
> Seems like we could parameterize these tests with JUnit and then not need all these separate
test classes.
> Another note, the tests will randomly return instead of running the test. Using {{Assume}}
instead would make it more clear in the test output that these tests were skipped.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message