hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rushabh S Shah (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10391) Always enable NameNode service RPC port
Date Thu, 14 Sep 2017 16:23:01 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166535#comment-16166535
] 

Rushabh S Shah commented on HDFS-10391:
---------------------------------------

This change breaks when we don't want to enable the service rpc port.
{noformat}
  public static InetSocketAddress getServiceAddress(Configuration conf) {
    String address = conf.getTrimmed(DFS_NAMENODE_SERVICE_RPC_ADDRESS_KEY);
    if (address == null || address.isEmpty()) {
      InetSocketAddress rpcAddress = DFSUtilClient.getNNAddress(conf);
      return NetUtils.createSocketAddr(rpcAddress.getHostName(),
          HdfsClientConfigKeys.DFS_NAMENODE_SERVICE_RPC_PORT_DEFAULT);
    }
    return NetUtils.createSocketAddr(address,
        HdfsClientConfigKeys.DFS_NAMENODE_SERVICE_RPC_PORT_DEFAULT);
  }
{noformat}
bq. The NameNode should always be setup with a service RPC port so that it does not have to
be explicitly enabled by an administrator.
>From the jira description, I infer that we can disable the service port if we want to.
But from the above code, we *can't* disable the service rpc port even if we want to.
[~eepayne] was not able to start a pseudo cluster on trunk because datanode was not able to
talk to namenode.
So I am -1 on this patch.
Please revert back and fix it.

> Always enable NameNode service RPC port
> ---------------------------------------
>
>                 Key: HDFS-10391
>                 URL: https://issues.apache.org/jira/browse/HDFS-10391
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode, namenode
>            Reporter: Arpit Agarwal
>            Assignee: Gergely Novák
>              Labels: Incompatible
>             Fix For: 3.0.0-beta1
>
>         Attachments: HDFS-10391.001.patch, HDFS-10391.002.patch, HDFS-10391.003.patch,
HDFS-10391.004.patch, HDFS-10391.005.patch, HDFS-10391.006.patch, HDFS-10391.007.patch, HDFS-10391.008.patch,
HDFS-10391.009.patch, HDFS-10391.010.patch, HDFS-10391.v5-v6-delta.patch
>
>
> The NameNode should always be setup with a service RPC port so that it does not have
to be explicitly enabled by an administrator.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message