Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 35A7A200CDF for ; Thu, 17 Aug 2017 22:35:06 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 3242A16BB83; Thu, 17 Aug 2017 20:35:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 77BD916BB81 for ; Thu, 17 Aug 2017 22:35:05 +0200 (CEST) Received: (qmail 6354 invoked by uid 500); 17 Aug 2017 20:35:03 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 6343 invoked by uid 99); 17 Aug 2017 20:35:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Aug 2017 20:35:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id DCD2F1A1BE2 for ; Thu, 17 Aug 2017 20:35:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id PBA04n0ewpuL for ; Thu, 17 Aug 2017 20:35:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id D5E035FBBA for ; Thu, 17 Aug 2017 20:35:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 1B84DE0217 for ; Thu, 17 Aug 2017 20:35:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id C97332537F for ; Thu, 17 Aug 2017 20:35:00 +0000 (UTC) Date: Thu, 17 Aug 2017 20:35:00 +0000 (UTC) From: "Yongjun Zhang (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-12316) Verify HDFS snapshot deletion doesn't crash the ongoing file writes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 17 Aug 2017 20:35:06 -0000 [ https://issues.apache.org/jira/browse/HDFS-12316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131255#comment-16131255 ] Yongjun Zhang commented on HDFS-12316: -------------------------------------- Thanks [~manojg], the patch looks good to me, except can we add some comments at the snapshot deletion call places to describe the intention, what problem we observed etc. I'm +1 other than that. > Verify HDFS snapshot deletion doesn't crash the ongoing file writes > ------------------------------------------------------------------- > > Key: HDFS-12316 > URL: https://issues.apache.org/jira/browse/HDFS-12316 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 3.0.0-beta1 > Reporter: Manoj Govindassamy > Assignee: Manoj Govindassamy > Attachments: HDFS-12316.01.patch > > > Recently we encountered a case where deletion of HDFS snapshots crashed the client that is currently writing to a file under the same snap root. This open file was previously captured in the snapshot using the immutable open file in snapshot feature "dfs.namenode.snapshot.capture.openfiles". -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org