Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C7DDC1666FC for ; Tue, 22 Aug 2017 10:05:09 +0200 (CEST) Received: (qmail 60811 invoked by uid 500); 22 Aug 2017 08:05:08 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 60800 invoked by uid 99); 22 Aug 2017 08:05:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Aug 2017 08:05:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 53620C2EC9 for ; Tue, 22 Aug 2017 08:05:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id cxDdpKuX_n-c for ; Tue, 22 Aug 2017 08:05:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 7A9265FE66 for ; Tue, 22 Aug 2017 08:05:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0C1F4E0ECF for ; Tue, 22 Aug 2017 08:05:03 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 20E82253A1 for ; Tue, 22 Aug 2017 08:05:01 +0000 (UTC) Date: Tue, 22 Aug 2017 08:05:01 +0000 (UTC) From: "Mukul Kumar Singh (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-12292) Federation: Support viewfs:// schema path for DfsAdmin commands MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-12292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136484#comment-16136484 ] Mukul Kumar Singh commented on HDFS-12292: ------------------------------------------ Thanks for the updated patch [~erofeev], 1) DFSAdmin.java:126, Should the condition inside the if statement should be changed to ViewFileSystem ? As this line contradicts the if statement on 130. 2) PathData.java:321 and 325, I feel that line 325 will always be true when 321 is true. Can one of these conditions be avoided ? 3) PathData.java:325, should there be a check for filesystem scheme here? > Federation: Support viewfs:// schema path for DfsAdmin commands > --------------------------------------------------------------- > > Key: HDFS-12292 > URL: https://issues.apache.org/jira/browse/HDFS-12292 > Project: Hadoop HDFS > Issue Type: Improvement > Components: federation > Reporter: Mikhail Erofeev > Assignee: Mikhail Erofeev > Attachments: HDFS-12292-002.patch, HDFS-12292-003.patch, HDFS-12292-004.patch, HDFS-12292.patch > > > Motivation: > As of now, clients need to specify a nameservice when a cluster is federated, otherwise, the exception is fired: > {code} > hdfs dfsadmin -setQuota 10 viewfs://vfs-root/user/uname > setQuota: FileSystem viewfs://vfs-root/ is not an HDFS file system > # with fs.defaultFS = viewfs://vfs-root/ > hdfs dfsadmin -setQuota 10 vfs-root/user/uname > setQuota: FileSystem viewfs://vfs-root/ is not an HDFS file system > # works fine thanks to https://issues.apache.org/jira/browse/HDFS-11432 > hdfs dfsadmin -setQuota 10 hdfs://users-fs/user/uname > {code} > This creates inconvenience, inability to rely on fs.defaultFS and forces to create client-side mappings for management scripts > Implementation: > PathData that is passed to commands should be resolved to its actual FileSystem > Result: > ViewFS will be resolved to the actual HDFS file system -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org