Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 10 Aug 2017 18:49:00 +0000 (UTC)
From: "Mukul Kumar Singh (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.13091657.1501616709000.2527.1502390940161@Atlassian.JIRA>
In-Reply-To: <JIRA.13091657.1501616709000@Atlassian.JIRA>
References: <JIRA.13091657.1501616709000@Atlassian.JIRA> <JIRA.13091657.1501616709115@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HDFS-12238) Ozone: Add valid trace ID check in
 sendCommandAsync
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Thu, 10 Aug 2017 18:49:05 -0000


    [ https://issues.apache.org/jira/browse/HDFS-12238?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1612=
2092#comment-16122092 ]=20

Mukul Kumar Singh commented on HDFS-12238:
------------------------------------------

[~anu] Yes, We can commit this patch, HDFS-12255 will fix Cblock test failu=
res.

> Ozone: Add valid trace ID check in sendCommandAsync
> ---------------------------------------------------
>
>                 Key: HDFS-12238
>                 URL: https://issues.apache.org/jira/browse/HDFS-12238
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Anu Engineer
>            Assignee: Ajay Yadav
>              Labels: newbie
>         Attachments: HDFS-12238-HDFS-7240.01.patch
>
>
> In the function {{XceiverClientHandler#sendCommandAsync}} we should add a=
 check=20
> {code}
> =E2=80=82=E2=80=82=E2=80=82if(StringUtils.isEmpty(request.getTraceID())) =
{
> =E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82throw new IllegalAr=
gumentException("Invalid trace ID");
> =E2=80=82=E2=80=82=E2=80=82=E2=80=82}
> {code}
> To ensure that ozone clients always send a valid trace ID. However, when =
you do that a set of current tests that do add a valid trace ID will fail. =
So we need to fix these tests too.
> {code}
>   TestContainerMetrics.testContainerMetrics
>   TestOzoneContainer.testBothGetandPutSmallFile
>   TestOzoneContainer.testCloseContainer
>   TestOzoneContainer.testOzoneContainerViaDataNode
>   TestOzoneContainer.testXcieverClientAsync
>   TestOzoneContainer.testCreateOzoneContainer
>   TestOzoneContainer.testDeleteContainer
>   TestContainerServer.testClientServer
>   TestContainerServer.testClientServerWithContainerDispatcher
>   TestKeys.testPutAndGetKeyWithDnRestart
> {code}
> This is based on a comment from [~vagarychen] in HDFS-11580.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org