Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 40AC7200CFC for ; Wed, 23 Aug 2017 12:11:06 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 3F0DA168498; Wed, 23 Aug 2017 10:11:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8AB86168499 for ; Wed, 23 Aug 2017 12:11:05 +0200 (CEST) Received: (qmail 61092 invoked by uid 500); 23 Aug 2017 10:11:03 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 61071 invoked by uid 99); 23 Aug 2017 10:11:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Aug 2017 10:11:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id CA03CC0718 for ; Wed, 23 Aug 2017 10:11:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id V59Mv9_4zTJf for ; Wed, 23 Aug 2017 10:11:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id C06CA61DB2 for ; Wed, 23 Aug 2017 10:11:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 20024E099F for ; Wed, 23 Aug 2017 10:11:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6D15A25385 for ; Wed, 23 Aug 2017 10:11:00 +0000 (UTC) Date: Wed, 23 Aug 2017 10:11:00 +0000 (UTC) From: "Surendra Singh Lilhore (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-12225) [SPS]: Optimize extended attributes for tracking SPS movements MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 23 Aug 2017 10:11:06 -0000 [ https://issues.apache.org/jira/browse/HDFS-12225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138187#comment-16138187 ] Surendra Singh Lilhore commented on HDFS-12225: ----------------------------------------------- Thanks [~umamaheswararao] for review.. bq. . Seems like we have 2 kind of classes I can see for tracking the info. 1. ItemInfo for tracking attempted items 2. SatisfyTrackInfo - for tracking storage movement needed items. Should we unify that class naming? How about something like, SatisfyTrackInfo --> ItemInfo and ItemInfo --> AttemptedItemInfo( extends ItemInfo ?) . Does this make sense to you? Yes, it make sense. Attached updated patch, please review... > [SPS]: Optimize extended attributes for tracking SPS movements > -------------------------------------------------------------- > > Key: HDFS-12225 > URL: https://issues.apache.org/jira/browse/HDFS-12225 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: datanode, namenode > Reporter: Uma Maheswara Rao G > Assignee: Surendra Singh Lilhore > Attachments: HDFS-12225-HDFS-10285-01.patch, HDFS-12225-HDFS-10285-02.patch, HDFS-12225-HDFS-10285-03.patch, HDFS-12225-HDFS-10285-04.patch, HDFS-12225-HDFS-10285-05.patch, HDFS-12225-HDFS-10285-06.patch, HDFS-12225-HDFS-10285-07.patch, HDFS-12225-HDFS-10285-08.patch, HDFS-12225-HDFS-10285-09.patch > > > We have discussed to optimize number extended attributes and asked to report separate JIRA while implementing [HDFS-11150 | https://issues.apache.org/jira/browse/HDFS-11150?focusedCommentId=15766127&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15766127] > This is the JIRA to track that work > For the context, comment copied from HDFS-11150 > {quote} > [~yuanbo] wrote : I've tried that before. There is an issue here if we only mark the directory. When recovering from FsImage, the InodeMap isn't built up, so we don't know the sub-inode of a given inode, in the end, We cannot add these inodes to movement queue in FSDirectory#addToInodeMap, any thoughts?{quote} > {quote} > [~umamaheswararao] wrote: I got what you are saying. Ok for simplicity we can add for all Inodes now. For this to handle 100%, we may need intermittent processing, like first we should add them to some intermittentList while loading fsImage, once fully loaded and when starting active services, we should process that list and do required stuff. But it would add some additional complexity may be. Let's do with all file inodes now and we can revisit later if it is really creating issues. How about you raise a JIRA for it and think to optimize separately? > {quote} > {quote} > [~andrew.wang] wrote in HDFS-10285 merge time review comment : HDFS-10899 also the cursor of the iterator in the EZ root xattr to track progress and handle restarts. I wonder if we can do something similar here to avoid having an xattr-per-file being moved. > {quote} -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org