hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anu Engineer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12321) Ozone : debug cli: add support to load user-provided SQL query
Date Thu, 24 Aug 2017 22:52:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16140877#comment-16140877

Anu Engineer commented on HDFS-12321:

[~vagarychen] This looks fantastic. Thanks for getting this working. Some very minor comments
on patch v8.

* DiskBalancerCLI.java, TestDBInputFormat.java, TestDbClasses.java -- There is an accidental
edit in each of these files.

* SQLQueryCLI -- Help string which embeds Json in the help string needs to be updated to the
new format.

* We should add a default OzoneQuery.json with the queries we know, feel free to do this in
a later JIRA too.

* SQLQueryCLI#parseOptions - {{.withArgName("property=value")}} -- should we actually have
the argument name here ? Probably a for loop to add each one of them ? if this is a place
holder for code review, then it is correct.

* cmds.json : nit : this comment seems to be incomplete.
"desc":"Count the total number of buckets under a specific volume.\nArgs : -volumeName  --
Volume name, required."
Can you also test stand alone on a DB and see if it works, that is independent of the Unit

> Ozone : debug cli: add support to load user-provided SQL query
> --------------------------------------------------------------
>                 Key: HDFS-12321
>                 URL: https://issues.apache.org/jira/browse/HDFS-12321
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Chen Liang
>            Assignee: Chen Liang
>             Fix For: ozone
>         Attachments: HDFS-12321-HDFS-7240.001.patch, HDFS-12321-HDFS-7240.002.patch,
HDFS-12321-HDFS-7240.003.patch, HDFS-12321-HDFS-7240.004.patch, HDFS-12321-HDFS-7240.005.patch,
HDFS-12321-HDFS-7240.006.patch, HDFS-12321-HDFS-7240.007.patch, HDFS-12321-HDFS-7240.008.patch
> This JIRA extends SQL CLI to support loading a user-provided file that includes any sql
query the user wants to run on the SQLite db obtained by converting Ozone metadata db.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message