hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiao Chen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12245) Update INodeId javadoc
Date Wed, 02 Aug 2017 16:43:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111252#comment-16111252
] 

Xiao Chen commented on HDFS-12245:
----------------------------------

>From [this comment|https://issues.apache.org/jira/browse/HDFS-4434?focusedCommentId=13629097&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13629097],
this looks to be intentional.
bq. First I think Sanjay's comment meant not reserving bits, but reserving range of numbers.
That is 0-16385 is reserved for future purposes.

> Update INodeId javadoc
> ----------------------
>
>                 Key: HDFS-12245
>                 URL: https://issues.apache.org/jira/browse/HDFS-12245
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>            Reporter: Wei-Chiu Chuang
>
> The INodeId javadoc states that id 1 to 1000 is reserved and root inode id start from
1001. That is no longer true after HDFS-4434.
> Also, it's a little weird in INodeId
> {code}
>   public static final long LAST_RESERVED_ID = 2 << 14 - 1;
>   public static final long ROOT_INODE_ID = LAST_RESERVED_ID + 1;
> {code}
> It seems the intent was for LAST_RESERVED_ID to be (2^14) - 1 = 32767. But due to Java
operator precedence, LAST_RESERVED_ID = 2^(14-1) = 16384. Maybe it doesn't matter, not sure.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message