hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Kumar (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-12238) Ozone: Add valid trace ID check in sendCommandAsync
Date Wed, 16 Aug 2017 20:31:00 GMT

     [ https://issues.apache.org/jira/browse/HDFS-12238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ajay Kumar updated HDFS-12238:
------------------------------
    Attachment: HDFS-12238-HDFS-7240.03.patch

> Ozone: Add valid trace ID check in sendCommandAsync
> ---------------------------------------------------
>
>                 Key: HDFS-12238
>                 URL: https://issues.apache.org/jira/browse/HDFS-12238
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Anu Engineer
>            Assignee: Ajay Kumar
>              Labels: newbie
>         Attachments: HDFS-12238-HDFS-7240.01.patch, HDFS-12238-HDFS-7240.02.patch, HDFS-12238-HDFS-7240.03.patch
>
>
> In the function {{XceiverClientHandler#sendCommandAsync}} we should add a check 
> {code}
>    if(StringUtils.isEmpty(request.getTraceID())) {
>       throw new IllegalArgumentException("Invalid trace ID");
>     }
> {code}
> To ensure that ozone clients always send a valid trace ID. However, when you do that
a set of current tests that do add a valid trace ID will fail. So we need to fix these tests
too.
> {code}
>   TestContainerMetrics.testContainerMetrics
>   TestOzoneContainer.testBothGetandPutSmallFile
>   TestOzoneContainer.testCloseContainer
>   TestOzoneContainer.testOzoneContainerViaDataNode
>   TestOzoneContainer.testXcieverClientAsync
>   TestOzoneContainer.testCreateOzoneContainer
>   TestOzoneContainer.testDeleteContainer
>   TestContainerServer.testClientServer
>   TestContainerServer.testClientServerWithContainerDispatcher
>   TestKeys.testPutAndGetKeyWithDnRestart
> {code}
> This is based on a comment from [~vagarychen] in HDFS-11580.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message