hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Manoj Govindassamy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11912) Add a snapshot unit test with randomized file IO operations
Date Thu, 24 Aug 2017 17:50:02 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16140388#comment-16140388
] 

Manoj Govindassamy commented on HDFS-11912:
-------------------------------------------

Thanks for your persistent efforts on this [~ghuangups], much appreciated. Just a couple of
more nits w.r.t checkstyle. 
+1, pending below nits.  
(1) Since {{TestRandomOpsWithSnapshots}} is a newly added test class, we prefer adding a proper
javadoc style comments on the goals of the test in line 56. 
(2) Also, please take a look at line 562, 563, and 624 for spaces and braces. 


> Add a snapshot unit test with randomized file IO operations
> -----------------------------------------------------------
>
>                 Key: HDFS-11912
>                 URL: https://issues.apache.org/jira/browse/HDFS-11912
>             Project: Hadoop HDFS
>          Issue Type: Test
>          Components: hdfs
>            Reporter: George Huang
>            Assignee: George Huang
>            Priority: Minor
>              Labels: TestGap
>         Attachments: HDFS-11912.001.patch, HDFS-11912.002.patch, HDFS-11912.003.patch,
HDFS-11912.004.patch, HDFS-11912.005.patch, HDFS-11912.006.patch
>
>
> Adding a snapshot unit test with randomized file IO operations.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message