hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anu Engineer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11580) Ozone: Support asynchronus client API for SCM and containers
Date Tue, 01 Aug 2017 01:00:49 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108229#comment-16108229
] 

Anu Engineer commented on HDFS-11580:
-------------------------------------

[~vagarychen], [~linyiqun], [~nanda], [~msingh] Thanks for the patches and code reviews. I
think one of my old changes is creating a road block in this work. Allow me to explain.

# When I first wrote this code, I wanted to offer a synchronous interface to make it easy
to write clients. So I painfully wrapped the Async interface offered by Netty into a Sync
one -- Probably due to a mistaken impression that it will make the life of programmers easy.
# Then when we came to do the async work -- what we should have done in the first place is
to make the underlying netty's async interface first class, which is currently hidden under
the {{sendCommand}} function.
# Instead, since the code already offers a synchronous interface, this code patch tries to
create a thread pool and attempts to call into the "Sync" interface offered by the XcieverClient.
I propose that we *don't* use a thread pool to make the "sync" -> "async", instead, we
expose the async interface as-is.
# Since I wrote the original code, I propose that I post a patch with the idea that I am talking
about so that we can see what I am proposing. Please let me know if you have any concerns
or questions.


> Ozone: Support asynchronus client API for SCM and containers
> ------------------------------------------------------------
>
>                 Key: HDFS-11580
>                 URL: https://issues.apache.org/jira/browse/HDFS-11580
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Anu Engineer
>            Assignee: Yiqun Lin
>         Attachments: HDFS-11580-HDFS-7240.001.patch, HDFS-11580-HDFS-7240.002.patch,
HDFS-11580-HDFS-7240.003.patch, HDFS-11580-HDFS-7240.004.patch, HDFS-11580-HDFS-7240.005.patch,
HDFS-11580-HDFS-7240.006.patch, HDFS-11580-HDFS-7240.007.patch, HDFS-11580-HDFS-7240.008.patch,
HDFS-11580-HDFS-7240.009.patch, HDFS-11580-HDFS-7240.010.patch, HDFS-11580-HDFS-7240.011.patch
>
>
> This is an umbrella JIRA that needs to support a set of APIs in Asynchronous form.
> For containers -- or the datanode API currently supports a call {{sendCommand}}. we need
to build proper programming interface and support an async interface.
> There is also a set of SCM API that clients can call, it would be nice to support Async
interface for those too.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message